Skip to content

feat(obs): add http metric for for envoy #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pggb25 wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

feat(obs): add http metric for for envoy #2361

pggb25 wants to merge 4 commits into from

Conversation

@pggb25
Copy link
Collaborator

@pggb25 pggb25 commented Feb 4, 2026 •
edited
Loading

Summary

This PR add the support for Envoy in the HTTP graph.
You can check it here
you have the both mode enabled. first envoy then nginx

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

RemiBonnet commented Feb 4, 2026

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

One day they will all understand

@pggb25 pggb25 changed the title feat: add http metric for for envoy feat(obs): add http metric for for envoy Feb 4, 2026
@pggb25 pggb25 force-pushed the feat/envoy-only-http-metrics branch from 422ac11 to 5261b0d Compare February 4, 2026 09:32
@codecov
Copy link

codecov bot commented Feb 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 13.42282% with 129 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.27%. Comparing base (8219801) to head (503fccd).
⚠️ Report is 2 commits behind head on staging.

Files with missing lines Patch % Lines
...-duration-chart/network-request-duration-chart.tsx 0.00% 42 Missing ⚠️
...uest-status-chart/network-request-status-chart.tsx 0.00% 33 Missing ⚠️
...-request-size-chart/network-request-size-chart.tsx 0.00% 27 Missing ⚠️
...e-http-errors-chart/instance-http-errors-chart.tsx 0.00% 18 Missing ⚠️
...b/hooks/use-http-route-name/use-http-route-name.ts 0.00% 3 Missing ⚠️
...ib/service/service-dashboard/service-dashboard.tsx 0.00% 2 Missing ⚠️
.../feature/src/lib/util-filter/dashboard-context.tsx 50.00% 1 Missing and 1 partial ⚠️
...y/feature/src/lib/hooks/use-metrics/use-metrics.ts 0.00% 1 Missing ⚠️
libs/shared/ui/src/lib/components/chart/chart.tsx 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8219801) and HEAD (503fccd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8219801) HEAD (503fccd)
unittests 2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           staging    #2361      +/-   ##
===========================================
- Coverage    52.38%   47.27%   -5.11%     
===========================================
  Files          381     1222     +841     
  Lines         7949    22534   +14585     
  Branches      2432     6672    +4240     
===========================================
+ Hits          4164    10654    +6490     
- Misses        3008     9865    +6857     
- Partials       777     2015    +1238
Flag Coverage Δ
unittests 47.27% <13.42%> (-5.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pggb25 pggb25 force-pushed the feat/envoy-only-http-metrics branch 2 times, most recently from 4cbb84e to 9ce6445 Compare February 4, 2026 10:11
pggb25 added 2 commits February 4, 2026 12:08
@pggb25
feat: add http metric for for envoy
fc1a6b5
@pggb25
fix(obs): calculate queryTimeRange for custom date ranges
e5ed776 
  When users select a custom time range, queryTimeRange was returning
  custom instead of calculating the actual duration, which created
  invalid Prometheus queries like [custom:5m].

  Now queryTimeRange calculates the duration in minutes from timestamps
  for both custom ranges and zoomed charts, ensuring valid queries.
@pggb25 pggb25 force-pushed the feat/envoy-only-http-metrics branch from dcc8808 to e5ed776 Compare February 4, 2026 11:08
pggb25 added 2 commits February 4, 2026 12:15
@pggb25
fix(ui): escape special chars in chart legend hover
6c15887 
  Use CSS.escape() to handle dataKeys with special characters (quotes,
  braces, etc.) in CSS selectors for legend hover highlighting.
@pggb25
fix: do not show envoy metrics if envoy is not enabled
503fccd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pggb25 @RemiBonnet